fix: check if git exists without calling the program for windows install#178
fix: check if git exists without calling the program for windows install#178
Conversation
zimeg
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
- Coverage 64.57% 64.53% -0.04%
==========================================
Files 213 213
Lines 17915 17915
==========================================
- Hits 11568 11561 -7
- Misses 5273 5278 +5
- Partials 1074 1076 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
🗣️ Update on happenings of this PR.
scripts/install-windows-dev.ps1
Outdated
| delay 0.3 "Now checking if it's the same Slack CLI..." | ||
| } | ||
| & $SLACK_CLI_NAME _fingerprint | Tee-Object -Variable get_finger_print | Out-Null | ||
| & $SLACK_CLI_NAME --version | Tee-Object -Variable slack_cli_version | Out-Null |
There was a problem hiding this comment.
👁️🗨️ note: Great findings from @ewanek1 hint that this _fingerprint might be causing CI to hang on a first installation?
zimeg
changed the title
zimeg
requested review from
hello-ashleyintech
and removed request for
ewanek1
hello-ashleyintech
left a comment
hello-ashleyintech
left a comment
There was a problem hiding this comment.
windows getting some luv 🚢
|
@hello-ashleyintech No doubt! It feels nice to be finding cause of this after so much search 🔍 ✨ Huge thanks for the review and efforts of @ewanek1 for getting us started on this before reports were raised. Let's get this merged! |
2 participants
Summary
This PR checks for if an installed
gitcommand exists on Windows. Fixes an issue where calling the installedgitcommand without arguments caused the program to return with an error after completing the installation!Reviewers
The following commands can be used to test these changes! 🔍
Requirements